Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename logback mdc library package name #7752

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Rename logback mdc library package name #7752

merged 1 commit into from
Feb 7, 2023

Conversation

trask
Copy link
Member

@trask trask commented Feb 7, 2023

(should help with this issue:)

Firstly in https://github.com/ff-sdesai/distributed-tracing-spring/blob/main/spring-cloud-sleuth-otel-slf4j/src/main/resources/logback.xml#L13 you are using io.opentelemetry.instrumentation.logback.v1_0.OpenTelemetryAppender this is the appender for mdc instrumentation. For exporting logs you'll need io.opentelemetry.instrumentation.logback.appender.v1_0.OpenTelemetryAppender.

@trask trask requested a review from a team as a code owner February 7, 2023 00:52
@laurit laurit changed the title Rename log4j mdc library package name Rename logback mdc library package name Feb 7, 2023
@trask trask merged commit 7091719 into open-telemetry:main Feb 7, 2023
@trask trask deleted the package-name branch February 7, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trask @mateuszrzeszutek