Change Spring Scheduling to not capture span for one-time jobs (only repeated jobs) #7760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
changed the title
trask
reviewed
Feb 8, 2023
...emetry/javaagent/instrumentation/spring/scheduling/v3_1/SpringSchedulingRunnableWrapper.java
Outdated
Show resolved
Hide resolved
…n/java/io/opentelemetry/javaagent/instrumentation/spring/scheduling/v3_1/SpringSchedulingRunnableWrapper.java
trask
approved these changes
Feb 11, 2023
There was a problem hiding this comment.
thx @heyams!
(and thanks @mateuszrzeszutek for the idea to only instrument repeating jobs!)
...telemetry/javaagent/instrumentation/spring/scheduling/v3_1/TaskSchedulerInstrumentation.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Feb 13, 2023
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
heyams
changed the title
heyams
added a commit
to microsoft/ApplicationInsights-Java
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing examples where Spring Scheduling INTERNAL spans are created inside of an existing parent span, which creates unnecessary noise.
And these spans don't necessary make sense as these are not "background jobs" (since they occur inside of an existing span).
(see for example microsoft/ApplicationInsights-Java#2870)
This PR changes Spring Scheduling instrumentation to only instrumenting repeating jobs, not one-time scheduled jobs (which corresponds to ScheduledExecutorService behavior where context is not propagated to runnable)