Make AggregationTemporality configurable for OtlpInMemoryMetricExporter #7904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ptrdom
force-pushed
the
agent-for-testing-temporality-config
branch
from
231b5dc
to
f2520c3
Compare
trask
reviewed
Feb 24, 2023
...er/src/main/java/io/opentelemetry/javaagent/testing/exporter/OtlpInMemoryMetricExporter.java
Show resolved
Hide resolved
| private final Queue<byte[]> collectedRequests = new ConcurrentLinkedQueue<>(); | ||
|
|
||
| private final AggregationTemporality aggregationTemporality; |
There was a problem hiding this comment.
can this be static, e.g.
Suggested change
| private final AggregationTemporality aggregationTemporality; | |
| private static final AggregationTemporality aggregationTemporality = initAggregationTemporality(); |
ptrdom
force-pushed
the
agent-for-testing-temporality-config
branch
from
f74723c
to
62850f2
Compare
ptrdom
force-pushed
the
agent-for-testing-temporality-config
branch
from
62850f2
to
5a63914
Compare
laurit
reviewed
Feb 27, 2023
| if (temporalityProperty == null) { | ||
| aggregationTemporality = AggregationTemporality.DELTA; | ||
| } else { | ||
| aggregationTemporality = AggregationTemporality.valueOf(temporalityProperty.toUpperCase()); |
There was a problem hiding this comment.
use toUpperCase(Locale.ROOT)
laurit
approved these changes
Feb 27, 2023
trask
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #7902.
Not sure if system property name is the most appropriate or if any tests are required for these changes.