Improve pulsar instrumentation #8007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @tjiuming |
|
it creates a new |
...ain/java/io/opentelemetry/javaagent/instrumentation/pulsar/v2_8/telemetry/PulsarRequest.java
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/javaagent/instrumentation/pulsar/v2_8/telemetry/PulsarSingletons.java
Outdated
Show resolved
Hide resolved
| .addAttributesExtractor( | ||
| MessagingAttributesExtractor.create(getter, MessageOperation.RECEIVE)) | ||
| NetClientAttributesExtractor.create(new PulsarNetClientAttributesGetter())) | ||
| .buildConsumerInstrumenter(MessageTextMapGetter.INSTANCE); |
There was a problem hiding this comment.
This should probably use the common messagingReceiveInstrumentationEnabled flag
Suggested change
| .buildConsumerInstrumenter(MessageTextMapGetter.INSTANCE); | |
| .setEnabled(ExperimentalConfig.get().messagingReceiveInstrumentationEnabled()) | |
| .buildConsumerInstrumenter(MessageTextMapGetter.INSTANCE); |
There was a problem hiding this comment.
If you don't mind I would work on this in a subsequent PR. As far as I understand using the messagingReceiveInstrumentationEnabled isn't enough to make it comply with spec, it should also use span link.
mateuszrzeszutek
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
message.typewith experimental attributemessaging.pulsar.message.type,message.typeis from rpc semantic conventionsnet.sock.peer.addrthat was filled with broker url withnet.peer.nameandnet.peer.port