Fix armeria latestDepTest #8247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Armeria 1.23 released a couple hours ago, and it looks like they changed a couple of things around the
HttpRequest&RequestHeadersimplementations.I removed the usage of
HttpRequest#uri()from the getters cause it threw IllegalStateException when one of the URI components was null. Instead, we're building the URI by hand now (which is pretty much the same thing Armeria does internally, sans the nullchecks).I also changed the way Armeria client is called in the tests -- while the previous version probably works, it generates totally wrong telemetry (I've no idea why it even works in the first place...).
RequestHeaders#path()expects just the path, not the full URI, and is unable to reconstruct the URI because it thinks that scheme and authority haven't been provided.