Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement HttpServerResponseCustomizer support for Undertow #8265

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Implement HttpServerResponseCustomizer support for Undertow #8265

merged 1 commit into from
Apr 11, 2023

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Apr 10, 2023

No description provided.

@laurit laurit requested a review from a team as a code owner April 10, 2023 17:35
breedx-splk
breedx-splk approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool to have some test coverage around the new behavior, but maybe it's already buried in the test framework somewhere that I don't know about. If not, I suppose that could be picked up in a following PR if you're inclined.

@trask trask merged commit bd7d141 into open-telemetry:main Apr 11, 2023
@laurit laurit deleted the undertow-response-customizer branch July 6, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask left review comments

@breedx-splk breedx-splk breedx-splk approved these changes

@tylerbenson tylerbenson tylerbenson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@laurit @trask @tylerbenson @breedx-splk