Deprecate InetSocketAddressNetServerAttributesGetter and move its met… #8341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hods to the interface
laurit
approved these changes
Apr 25, 2023
trask
approved these changes
May 26, 2023
mateuszrzeszutek
deleted the
deprecate-InetSocketAddressNetServerAttributesGetter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hods to the interface
I think at some point I mentioned that I had thought about making the HTTP semconv getter extend the net getters (and URL getters, user agent getters etc. once we migrate to ECS names) to mimic the way the HTTP semconv "extends" (includes attributes from) other semantic conventions. This PR is a prerequisite for that -- but it is useful on its own, I think, as it simplifies the story of implementing the net getters by removing the abstract
InetSocketAddressclass.Client side will be included in the next PR.