Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(propagators): ot-tracer and xray #838

Merged

Conversation

FrankSpitulski
Copy link
Contributor

adds a new propagator (already in the sdk), used by lightstep

used by lightstep
@FrankSpitulski
Copy link
Contributor Author

issue with ./gradlew :instrumentation:grpc-1.5:latestDepTest, unrelated I think (since it's occurring on #827 too)

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I always assumed b3 and jaeger are here since they're very common OSS propagators, though I guess it seems to make sense to configure anything in the extensions package. Can we add xray too? :-)

@FrankSpitulski
Copy link
Contributor Author

added xray. the list ended up getting too long for the ImmutableMap.of() function.

@FrankSpitulski FrankSpitulski changed the title feat(propagators): ot-tracer feat(propagators): ot-tracer and xray Jul 30, 2020
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! I'll let you know once the latestDepTest issue is resolved in master.

@trask trask merged commit 4cec42b into open-telemetry:master Jul 30, 2020
@FrankSpitulski FrankSpitulski deleted the feat/propagators/ot-tracer branch August 18, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants