Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce new incubating InstrumenterBuilder methods #8392

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Introduce new incubating InstrumenterBuilder methods #8392

merged 2 commits into from
Apr 28, 2023

Conversation

mateuszrzeszutek
Copy link
Member

This PR aims to unblock #8255 by adding two new methods to InstrumenterUtil, while we can debate the names in the meantime.

@mateuszrzeszutek mateuszrzeszutek requested a review from a team as a code owner April 28, 2023 11:28
@mateuszrzeszutek mateuszrzeszutek mentioned this pull request Apr 28, 2023
Merged
laurit
laurit approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@laurit laurit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I think we could avoid reflection by doing something like jdk does with JavaLangAccess and SharedSecrets. Or could set functions into InstrumenterUtil from clinit of Instrumenter.

@mateuszrzeszutek
Copy link
Member Author

Nice. I think we could avoid reflection by doing something like jdk does with JavaLangAccess and SharedSecrets. Or could set functions into InstrumenterUtil from clinit of Instrumenter.

Nice, I like that suggestion. I'll work on that.

@trask trask merged commit d22dd8c into open-telemetry:main Apr 28, 2023
@mateuszrzeszutek mateuszrzeszutek deleted the new-instrumenter-builder-methods branch April 29, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@laurit laurit laurit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mateuszrzeszutek @trask @laurit