Allow transforming classes with missing field types #8393
Conversation
| .with(MethodGraph.Compiler.ForDeclaredMethods.INSTANCE) | ||
| .with(VisibilityBridgeStrategy.Default.NEVER) | ||
| .with(InstrumentedType.Factory.Default.FROZEN)) | ||
| .with(AgentBuilder.TypeStrategy.Default.DECORATE) |
There was a problem hiding this comment.
DECORATE javadocs say that:
A decoration does not allow for any standard transformations but can be used as a performance optimization compared to a redefinition, especially when implementing a Java agent that only applies ASM-based code changes.
I'm not sure what "standard transformations" mean in this context; do you know if this has any extra limitations compared to the previous strategy?
There was a problem hiding this comment.
I had the same question, but the tests pass so it seems that it is working for our use case. I think that the advices that we use are only a small and very restrictive part of byte buddy transformations. It is possible that there is a difference when more complicated transforms are used.
There was a problem hiding this comment.
The only difference I noticed was the issue in #8391 where there was a failure instrumenting a static method with an advice that used this
Hopefully resolves #8276
Previously we had
SafeTypeStrategythat allowed transforming classes with missing method argument or return type. For this it filtered out such methods so that transformation wouldn't fail. Seems likeDECORATEstrategy doesn't perform such checks.