Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up EarlyInitAgentConfig even earlier #8413

Merged
merged 2 commits into from
May 6, 2023

Conversation

mateuszrzeszutek
Copy link
Member

Resolves #8396
And is an alternative approach to #8381

I moved the EarlyInitAgentConfig creation even earlier, allowing otel.javaagent.logging and otel.javaagent.extensions to be specified in the config file; and also cleaned up some of the debug mode usages, where apparently not all of the if (debug) branches would trigger if you enabled debug mode via config file.

@mateuszrzeszutek mateuszrzeszutek added this to the v1.26.0 milestone May 5, 2023
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit 9b82a01 into open-telemetry:main May 6, 2023
44 checks passed
@mateuszrzeszutek mateuszrzeszutek deleted the earlier-config branch May 8, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make otel.javaagent.logging configurable from file
3 participants