Disable the logging exporter by default #8647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
approved these changes
Jun 5, 2023
trask
approved these changes
Jun 5, 2023
|
@opentelemetrybot update |
devurandom
added a commit
to devurandom/timbre
that referenced
this pull request
Jun 19, 2023
Requires io.opentelemetry/opentelemetry-api.
With Java Agent:
Activate an appender configured by the OpenTelemetry Java Agent:
```clj
(let [logger-provider (.getLogsBridge (GlobalOpenTelemetry/get))
appender (taoensso.timbre.appenders.community.otlp/otlp-appender logger-provider)]
(taoensso.timbre/merge-config! {:appenders {:otlp appender}}))
```
Note: When relying on the OpenTelemetry Java Agent 1.x, you need
to explicitly enable the logs exporter with `OTEL_LOGS_EXPORTER=otlp`.
This will become the default with the release of Java Agent 2.0, cf.
* https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/CHANGELOG.md#version-1270-2023-06-14
* open-telemetry/opentelemetry-java-instrumentation#8647
Without Java Agent:
If you want autoconfiguration without the Java Agent, you also need
io.opentelemetry/opentelemetry-sdk-extension-autoconfigure and
io.opentelemetry/opentelemetry-exporter-otlp on the classpath.
Create an autoconfigured appender and activate it:
```clj
(let [logger-provider (.getSdkLoggerProvider
(.getOpenTelemetrySdk
(.build
(AutoConfiguredOpenTelemetrySdk/builder))))
appender (taoensso.timbre.appenders.community.otlp/otlp-appender logger-provider)]
(taoensso.timbre/merge-config! {:appenders {:otlp appender}}))
```
If you already have an instance of `GlobalOpenTelemetry`, e.g. created
by the OpenTelemetry Java Agent, you need to prevent setting the newly
created SDK as the global default:
```clj
(.build
(doto (AutoConfiguredOpenTelemetrySdk/builder)
(.setResultAsGlobal false)))
```
I took inspiration from `taoensso.timbre.appenders.community.sentry`.
Once steffan-westcott/clj-otel#8 is implemented,
the actual log emission should be replaced with using clj-otel's API.
devurandom
added a commit
to devurandom/timbre
that referenced
this pull request
Jun 19, 2023
Requires com.github.steffan-westcott/clj-otel-api.
With Java Agent:
Activate an appender configured by the OpenTelemetry Java Agent:
```clj
(let [logger-provider (.getLogsBridge (GlobalOpenTelemetry/get))
appender (taoensso.timbre.appenders.community.otlp/otlp-appender logger-provider)]
(taoensso.timbre/merge-config! {:appenders {:otlp appender}}))
```
Note: When relying on the OpenTelemetry Java Agent 1.x, you need
to explicitly enable the logs exporter with `OTEL_LOGS_EXPORTER=otlp`.
This will become the default with the release of Java Agent 2.0, cf.
* https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/CHANGELOG.md#version-1270-2023-06-14
* open-telemetry/opentelemetry-java-instrumentation#8647
Without Java Agent:
If you want autoconfiguration without the Java Agent, you also need
io.opentelemetry/opentelemetry-sdk-extension-autoconfigure and
io.opentelemetry/opentelemetry-exporter-otlp on the classpath.
Create an autoconfigured appender and activate it:
```clj
(let [logger-provider (.getSdkLoggerProvider
(.getOpenTelemetrySdk
(.build
(AutoConfiguredOpenTelemetrySdk/builder))))
appender (taoensso.timbre.appenders.community.otlp/otlp-appender logger-provider)]
(taoensso.timbre/merge-config! {:appenders {:otlp appender}}))
```
If you already have an instance of `GlobalOpenTelemetry`, e.g. created
by the OpenTelemetry Java Agent, you need to prevent setting the newly
created SDK as the global default:
```clj
(.build
(doto (AutoConfiguredOpenTelemetrySdk/builder)
(.setResultAsGlobal false)))
```
I took inspiration from `taoensso.timbre.appenders.community.sentry`.
Once steffan-westcott/clj-otel#8 is implemented,
the actual log emission should be replaced with using clj-otel's API.
devurandom
added a commit
to devurandom/timbre
that referenced
this pull request
Jun 19, 2023
Requires com.github.steffan-westcott/clj-otel-api.
With Java Agent:
Activate an appender configured by the OpenTelemetry Java Agent:
```clj
(let [logger-provider (.getLogsBridge (GlobalOpenTelemetry/get))
appender (taoensso.timbre.appenders.community.otlp/otlp-appender logger-provider)]
(taoensso.timbre/merge-config! {:appenders {:otlp appender}}))
```
Note: When relying on the OpenTelemetry Java Agent 1.x, you need
to explicitly enable the logs exporter with `OTEL_LOGS_EXPORTER=otlp`.
This will become the default with the release of Java Agent 2.0, cf.
* https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/CHANGELOG.md#version-1270-2023-06-14
* open-telemetry/opentelemetry-java-instrumentation#8647
Without Java Agent:
If you want autoconfiguration without the Java Agent, you also need
io.opentelemetry/opentelemetry-sdk-extension-autoconfigure and
io.opentelemetry/opentelemetry-exporter-otlp on the classpath.
Create an autoconfigured appender and activate it:
```clj
(let [logger-provider (.getSdkLoggerProvider
(.getOpenTelemetrySdk
(.build
(AutoConfiguredOpenTelemetrySdk/builder))))
appender (taoensso.timbre.appenders.community.otlp/otlp-appender logger-provider)]
(taoensso.timbre/merge-config! {:appenders {:otlp appender}}))
```
If you already have an instance of `GlobalOpenTelemetry`, e.g. created
by the OpenTelemetry Java Agent, you need to prevent setting the newly
created SDK as the global default:
```clj
(.build
(doto (AutoConfiguredOpenTelemetrySdk/builder)
(.setResultAsGlobal false)))
```
I took inspiration from `taoensso.timbre.appenders.community.sentry`.
Once steffan-westcott/clj-otel#8 is implemented,
the actual log emission should be replaced with using clj-otel's API.
devurandom
added a commit
to devurandom/timbre
that referenced
this pull request
Jun 19, 2023
Requires com.github.steffan-westcott/clj-otel-api.
With Java Agent:
Activate an appender configured by the OpenTelemetry Java Agent:
```clj
(let [logger-provider (.getLogsBridge (GlobalOpenTelemetry/get))
appender (taoensso.timbre.appenders.community.otlp/otlp-appender logger-provider)]
(taoensso.timbre/merge-config! {:appenders {:otlp appender}}))
```
Note: When relying on the OpenTelemetry Java Agent 1.x, you need
to explicitly enable the logs exporter with `OTEL_LOGS_EXPORTER=otlp`.
This will become the default with the release of Java Agent 2.0, cf.
* https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/CHANGELOG.md#version-1270-2023-06-14
* open-telemetry/opentelemetry-java-instrumentation#8647
Without Java Agent:
If you want autoconfiguration without the Java Agent, you also need
io.opentelemetry/opentelemetry-sdk-extension-autoconfigure and
io.opentelemetry/opentelemetry-exporter-otlp on the classpath.
Create an autoconfigured appender and activate it:
```clj
(let [logger-provider (.getSdkLoggerProvider
(.getOpenTelemetrySdk
(.build
(AutoConfiguredOpenTelemetrySdk/builder))))
appender (taoensso.timbre.appenders.community.otlp/otlp-appender logger-provider)]
(taoensso.timbre/merge-config! {:appenders {:otlp appender}}))
```
If you already have an instance of `GlobalOpenTelemetry`, e.g. created
by the OpenTelemetry Java Agent, you need to prevent setting the newly
created SDK as the global default:
```clj
(.build
(doto (AutoConfiguredOpenTelemetrySdk/builder)
(.setResultAsGlobal false)))
```
I took inspiration from `taoensso.timbre.appenders.community.sentry`.
Once steffan-westcott/clj-otel#8 is implemented,
the actual log emission should be replaced with using clj-otel's API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8633