Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix instrumentation for armeria 1.24 #8745

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Fix instrumentation for armeria 1.24 #8745

merged 1 commit into from
Jun 16, 2023

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Jun 16, 2023

Resolves #8743
Resolves #8744

@laurit laurit requested a review from a team as a code owner June 16, 2023 07:28
mateuszrzeszutek
mateuszrzeszutek approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, did the same thing just a minute ago mateuszrzeszutek@01ae163

@mateuszrzeszutek mateuszrzeszutek enabled auto-merge (squash) June 16, 2023 07:31
@mateuszrzeszutek mateuszrzeszutek merged commit ce084db into open-telemetry:main Jun 16, 2023
41 of 45 checks passed
@laurit laurit deleted the armeria-1.24 branch June 16, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workflow failed: Build (daily, --no-build-cache) (#450) Workflow failed: Build (daily) (#452)
2 participants
@laurit @mateuszrzeszutek