Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename common HTTP configuration settings #8758

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

mateuszrzeszutek
Copy link
Member

Split off from #8747

I think it makes sense to introduce that rename either way; since I'm planning to introduce things like otel.instrumentation.http.client.capture-experimental-metrics or otel.instrumentation.http.server.captured-request-methods

@mateuszrzeszutek mateuszrzeszutek requested a review from a team as a code owner June 19, 2023 09:17
Copy link
Contributor

@laurit laurit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to log a warning when deprecated property is used?

@trask trask merged commit eec8703 into open-telemetry:main Jun 28, 2023
45 checks passed
@mateuszrzeszutek mateuszrzeszutek deleted the rename-http-configs branch June 29, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants