Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(micrometer) don't add . to empty unit with prometheus naming conventions #8872

Merged
merged 2 commits into from
Jul 11, 2023
Merged

(micrometer) don't add . to empty unit with prometheus naming conventions #8872

merged 2 commits into from
Jul 11, 2023

Conversation

zeitlinger
Copy link
Member

don't add . to empty unit with prometheus naming conventions

@zeitlinger zeitlinger requested a review from a team as a code owner July 5, 2023 15:02
mateuszrzeszutek
mateuszrzeszutek approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@trask
Copy link
Member

trask commented Jul 5, 2023

@zeitlinger can you check the CI failure? thx!

@trask trask merged commit b3932c7 into open-telemetry:main Jul 11, 2023
45 checks passed
@zeitlinger zeitlinger deleted the empty_unit branch July 20, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@laurit laurit laurit approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zeitlinger @trask @laurit @mateuszrzeszutek