Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract query arguments without regex on lettuce 6 #8932

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Extract query arguments without regex on lettuce 6 #8932

merged 1 commit into from
Jul 12, 2023

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Jul 12, 2023

Related to #8907

@laurit laurit requested a review from a team as a code owner July 12, 2023 07:57
breedx-splk
breedx-splk approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks good to me! Seems like it should help reduce parsing costs. Thanks!

@trask trask merged commit 70247f0 into open-telemetry:main Jul 12, 2023
45 checks passed
@laurit laurit deleted the lettuce-arguments branch July 13, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breedx-splk breedx-splk breedx-splk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@laurit @breedx-splk @trask