Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill additional db.* attributes on DataSource#getConnection() #8966

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Fill additional db.* attributes on DataSource#getConnection() #8966

merged 2 commits into from
Jul 19, 2023

Conversation

mateuszrzeszutek
Copy link
Member

Resolves #8838

@mateuszrzeszutek mateuszrzeszutek requested a review from a team as a code owner July 18, 2023 12:24
@mateuszrzeszutek mateuszrzeszutek mentioned this pull request Jul 18, 2023
Closed
trask
trask approved these changes Jul 18, 2023
View reviewed changes
.../src/main/java/io/opentelemetry/instrumentation/jdbc/datasource/OpenTelemetryDataSource.java
@@ -128,25 +128,29 @@ public void close() throws Exception {
}
}

private <T, E extends SQLException> T wrapCall(ThrowingSupplier<T, E> callable) throws E {
private Connection wrapCall(ThrowingSupplier<Connection, SQLException> getConnection)
throws SQLException {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

breedx-splk
breedx-splk approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@trask trask merged commit 37531a0 into open-telemetry:main Jul 19, 2023
45 checks passed
@mateuszrzeszutek mateuszrzeszutek deleted the fill-db-info-on-getConnection branch July 20, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@breedx-splk breedx-splk breedx-splk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OTEL instrumentation to JDBC connection creation
3 participants
@mateuszrzeszutek @trask @breedx-splk