rename telemetry.auto.version to telemetry.distro.version and add telemetry.distro.name #9065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Jul 27, 2023
zeitlinger
force-pushed
the
auto-name
branch
from
0d04d1e
to
60001a5
Compare
laurit
reviewed
Dec 12, 2023
smoke-tests/src/test/groovy/io/opentelemetry/smoketest/AppServerTest.groovy
Outdated
Show resolved
Hide resolved
…erTest.groovy Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
|
@zeitlinger can you update the PR title? thx |
zeitlinger
changed the title
done |
elbiocaetano
pushed a commit
to elbiocaetano/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 19, 2023
…emetry.distro.name (open-telemetry#9065) Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
zzhlogin
added a commit
to aws-observability/aws-otel-python-instrumentation
that referenced
this pull request
Feb 27, 2024
*Issue #, if available:* In Java,` telemetry.auto.version` resource attribute is being deprecated ([PR](open-telemetry/opentelemetry-java-instrumentation#9065)). However, We don't find any related change in upstream. It is still [being used](https://github.com/open-telemetry/opentelemetry-python/blob/da48e0b131ff34ff382b7d1206f71b2e31929cab/opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py#L364), so we are not going to deprecate it in aws-opentelemetry-distro for now. And we use `aws-opentlemetry-distro` version with "-aws" post-fix to be the `telemetry.auto.version `, which match with the [Java implementation](https://github.com/aws-observability/aws-otel-java-instrumentation/blob/294e957afbf48e766e3be9a11638050ef3736904/otelagent/build.gradle.kts#L101). Testing: Tested resource attributed are generated: Before the change: ``` "resource": "BoundedAttributes({'telemetry.sdk.language': 'python', 'telemetry.sdk.name': 'opentelemetry', 'telemetry.sdk.version': '1.22.0', 'service.name': 'unknown_service', 'telemetry.auto.version': '0.43b0'}, maxlen=None)" ``` After the change: ``` "resource": "BoundedAttributes({'telemetry.sdk.language': 'python', 'telemetry.sdk.name': 'opentelemetry', 'telemetry.sdk.version': '1.22.0', 'service.name': 'unknown_service', 'telemetry.auto.version':'0.0.1-aws'}, maxlen=None)" ``` By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as defined in https://opentelemetry.io/docs/specs/semconv/resource/#telemetry-sdk-experimental