Added Automatic-Module-Name header to MANIFEST.MF in instrumentation libraries #9140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it make more sense to build the module name from gradle module name so you wouldn't need to manually add it? Perhaps use a similar logic to what the maven publishing process does, for example |
|
Module names should follow the pattern (to avoid conflicts with other modules):
Applying it
That gives you: Other examples (module names that share a prefix):
Providing the I do not see a problem putting the final module name today, once we got to an agreement (it should not be changed in the future). |
| @@ -186,6 +186,9 @@ testing { | |||
| } | |||
| } | |||
|
|
|||
| // module name | |||
| val moduleName: String? by extra | |||
There was a problem hiding this comment.
Instead of using extra, can you add that to the OtelJavaExtension? Also, consider naming it javaModuleName or javaModule to signify that it's the Java 9 module, not some arbitrary module name (e.g. gradle module).
the concern here is that it's a bit error prone, and we will need to remember to add this for all new modules that get added in the future it would be really nice if we could maybe add this generically, e.g. to |
…ntation libraries" This reverts commit 5a96981.
|
The Java module names are now auto-generated. |
|
I checked what these generated module names look like: |
laurit
approved these changes
Oct 3, 2023
mateuszrzeszutek
approved these changes
Oct 9, 2023
breedx-splk
approved these changes
Oct 10, 2023
|
I think some flattening might be better, similar to what we've done for instrumentation scope names, e.g.
instead of
because it would be a bit more resilient to re-arrangements of the repository, since currently the directory structure is encoded into the module names (EDIT sorry for the half-baked comment, I'll try to think more about this and propose something more concrete) |
Hmm, we could just skip all the directories between |
|
I reworked the module name algorithm to remove redundant segments from the module name |
mateuszrzeszutek
approved these changes
Oct 11, 2023
|
@laurit thx! one more thought, instead of
what do you think of
similar to our maven groupId strategy: https://search.maven.org/search?q=apache-dbcp-2.0 (and we could skip non-published artifacts if that helps) |
|
Customized handling for |
|
thanks @rjbaucells @laurit ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
Automatic-Module-Nameheader toMETA-INF/MANIFEST.MFjar file in instrumentation libraries. (see #9124)