Ignore aws sdk v2 presign requests #9275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
commented
Aug 22, 2023
|
|
||
| // Ignore presign request. These requests don't run all interceptor methods and the span created | ||
| // here would never be ended and scope closed. | ||
| if (executionAttributes.getAttribute(AwsSignerExecutionAttribute.SERVICE_SIGNING_NAME) |
There was a problem hiding this comment.
The assumption here is that nothing besides https://github.com/aws/aws-sdk-java-v2/blob/fcaf70fa89a7dccea210435488365f0a1ca1b609/services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/signing/DefaultS3Presigner.java#L332 set that attribute
laurit
force-pushed
the
aws-sdk-v2-presign
branch
from
812225a
to
6af5623
Compare
mateuszrzeszutek
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9238
Presign requests don't make an actual request to aws. They run only a subset of interceptor methods which cause a scope leak.