Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement client.port extraction in HTTP server instrumentations #9381

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Implement client.port extraction in HTTP server instrumentations #9381

merged 2 commits into from
Sep 7, 2023

Conversation

mateuszrzeszutek
Copy link
Member

Resolves #9009

@mateuszrzeszutek mateuszrzeszutek requested a review from a team as a code owner September 4, 2023 10:27
mateuszrzeszutek
mateuszrzeszutek commented Sep 4, 2023
View reviewed changes
...va/io/opentelemetry/instrumentation/api/instrumenter/http/ClientAddressAndPortExtractor.java
int portEnd = findPortEnd(forwarded, portStart + 1, end);
setPort(sink, forwarded, portStart + 1, portEnd);
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave up on parsing port in the no-brackets ipv6 case: I personally can't even recognise whether ::1:2 contains a port or not, let alone code it. (that's why you should use Forwarded and not X-Forwarded-For)

@trask trask merged commit 9cf710f into open-telemetry:main Sep 7, 2023
46 checks passed
@mateuszrzeszutek mateuszrzeszutek deleted the parse-client-port branch September 7, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit laurit laurit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement client.port extraction in HTTP server instrumentations
3 participants
@mateuszrzeszutek @laurit @trask