Implement error.type attribute in HTTP semconv #9466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
force-pushed
the
error-type
branch
2 times, most recently
from
87520b2
to
b5baecf
Compare
| * cancelled}, {@code _OTHER}. | ||
| */ | ||
| @Nullable | ||
| default String getErrorType( |
There was a problem hiding this comment.
I thought about creating a separate extractor just for that, but decided against it -- let's first see if there are any other use cases for this attribute, and we can retroactively implement a new getter interface if there's a need to do so.
trask
reviewed
Sep 19, 2023
...ain/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpStatusCodeConverter.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
force-pushed
the
error-type
branch
from
ab34cfa
to
86ae291
Compare
laurit
approved these changes
Sep 22, 2023
mateuszrzeszutek
force-pushed
the
error-type
branch
from
86ae291
to
0b8bf3b
Compare
|
@trask is there anything else blocking this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9438
Part of #9090