Instrument DefaultSpan.create to return a bridged span. #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 7, 2020 15:20
anuraaga
requested review from
iNikem,
jkwatson,
trask and
tylerbenson
as code owners
iNikem
reviewed
Aug 12, 2020
| @Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class) | ||
| public static void methodExit( | ||
| @Advice.Return(readOnly = false) unshaded.io.opentelemetry.trace.Span span) { | ||
| span = Bridging.toUnshaded(DefaultSpan.create(Bridging.toShaded(span.getContext()))); |
trask
approved these changes
Aug 12, 2020
|
Don't wait for me, I cannot bring myself to approving this :) |
mabdinur
pushed a commit
to mabdinur/opentelemetry-java-instrumentation
that referenced
this pull request
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Half of #764 - I realized that the issue actually shows two exceptions, Unexpected span and Unexpected context. Will continue to debug but figured it's worth getting this in first since it's ready.