Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make netty ChannelPipeline removeLast return user handler #9584

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Make netty ChannelPipeline removeLast return user handler #9584

merged 1 commit into from
Oct 2, 2023

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Sep 29, 2023

Resolves #9580

@laurit laurit requested a review from a team as a code owner September 29, 2023 20:13
trask
trask approved these changes Oct 2, 2023
View reviewed changes
.../opentelemetry/javaagent/instrumentation/netty/v4_0/NettyChannelPipelineInstrumentation.java
Comment on lines -51 to -52
* handlers. If those handlers are later removed, we may want to remove our handlers. That is not
* currently implemented.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit e368334 into open-telemetry:main Oct 2, 2023
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

netty pipeline remove method return the otlp handler
2 participants
@laurit @trask