Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: get route info in spring-cloud-gateway #9597

Merged
merged 15 commits into from
Nov 3, 2023
Merged

feat: get route info in spring-cloud-gateway #9597

merged 15 commits into from
Nov 3, 2023

Conversation

123liuziming
Copy link
Contributor

related to #9596

@123liuziming 123liuziming requested a review from a team as a code owner October 2, 2023 18:00
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 2, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@trask
Copy link
Member

trask commented Oct 31, 2023

@123liuziming can you add this to https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/docs/supported-libraries.md#libraries--frameworks?

under the last column (Semantic Conventions) you can put

Provides http.route [2]

@123liuziming
Copy link
Contributor Author

@123liuziming can you add this to https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/docs/supported-libraries.md#libraries--frameworks?

under the last column (Semantic Conventions) you can put

Provides http.route [2]

I've added under Spring Webflux item.

@laurit
Copy link
Contributor

laurit commented Nov 1, 2023

I've added under Spring Webflux item.

Alphabetical order would be preferable. The existing list is in alphabetical order except for a couple of outliers.

@laurit
Copy link
Contributor

laurit commented Nov 1, 2023

The same also applies to the oder of instrumentation modules in settings.gradle.kts

@123liuziming
Copy link
Contributor Author

Both are reordered

@123liuziming
Copy link
Contributor Author

image
There is a timeout during gradle-wrapper-validation.

@laurit
Copy link
Contributor

laurit commented Nov 3, 2023

@123liuziming I reran the failed workflow

@trask trask merged commit 702ae30 into open-telemetry:main Nov 3, 2023
47 checks passed
@trask
Copy link
Member

trask commented Nov 3, 2023

thx @123liuziming!

Abhishekkr3003 pushed a commit to Abhishekkr3003/opentelemetry-java-instrumentation that referenced this pull request Nov 7, 2023
@123liuziming @Abhishekkr3003
feat: get route info in spring-cloud-gateway (open-telemetry#9597)
1679c63
@123liuziming 123liuziming mentioned this pull request Jul 11, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit laurit laurit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@123liuziming @trask @laurit