Add support for newVirtualThreadPerTaskExecutor #9616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#9620 adds running tests with jdk 21 |
laurit
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the Java 21
Executors.newVirtualThreadPerTaskExecutor. Part of #9534 . This also implicitly testsExecutors.newThreadPerTaskExecutorbecausenewVirtualThreadPerTaskExecutoris implemented on top of it.This PR is in draft state because we should upgrade the ci tests to Java 21 first.
When testing locally, I noticed that the Lambda instrumentation broke, because for all lambda classes the
$$Lambda$<number>suffix was replaced with just$$Lambdawithout the number. I don't know if this is a property of Java 21 in general or whether this was specific to the EA-build I've been using: