Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve disableShadowRelocate #9715

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Improve disableShadowRelocate #9715

merged 3 commits into from
Oct 20, 2023

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Oct 19, 2023

Resolves #9711

@laurit laurit requested a review from a team as a code owner October 19, 2023 11:01
@123liuziming
Copy link
Contributor

123liuziming commented Oct 19, 2023 •
edited
Loading

I've tried to use a similar approach to fix the problem before, but some tests like SpringWebfluxTest failed. I 've not figured it out why the tests failed yet....
And I 've tried your solution locally, the SpringWebfluxTest failed as well:
image

@laurit
Copy link
Contributor Author

laurit commented Oct 19, 2023

@123liuziming it is expected that some tests will fail with this flag. From your screenshot it is not possible to tell why webflux tests fail.

@123liuziming
Copy link
Contributor

123liuziming commented Oct 19, 2023 •
edited
Loading

@123liuziming it is expected that some tests will fail with this flag. From your screenshot it is not possible to tell why webflux tests fail.

Sorry, I didn't read your comment in issue carefully. Now it does pass at least part of the tests！Thanks！:thumbsup: :thumbsup: :thumbsup:

@laurit @trask
Update javaagent-tooling/src/main/java/io/opentelemetry/javaagent/too…
7b95e25 
…ling/ExtensionClassLoader.java

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@laurit
Copy link
Contributor Author

laurit commented Oct 20, 2023

@123liuziming I made one more change that should also get the webflux tests passing

@laurit laurit merged commit 93e0667 into open-telemetry:main Oct 20, 2023
47 checks passed
@laurit laurit deleted the disable-shadow branch October 20, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests failed while setting disableShadowRelocate=true
4 participants
@laurit @123liuziming @trask @mateuszrzeszutek