Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress instrumentation based on suppress Context key #9739

Merged
merged 8 commits into from
Nov 17, 2023
Merged

Suppress instrumentation based on suppress Context key #9739

merged 8 commits into from
Nov 17, 2023

Conversation

LikeTheSalad
Copy link
Contributor

An approach to suppress automatic instrumentations based on the suppress_instrumentation Context key.

@LikeTheSalad LikeTheSalad requested a review from a team as a code owner October 23, 2023 11:48
@LikeTheSalad
Copy link
Contributor Author

Hi @jack-berg - If I understood correctly, these should be the changes we were talking about in last week's SIG. We will need to use a Context key defined in the OTel Java repo though, so I guess these changes would have to wait for a new release there that contains these changes. Please let me know if there's anything we should improve here or in the core repo's PR!

@trask trask added this to the v1.32.0 milestone Nov 16, 2023
@LikeTheSalad
Copy link
Contributor Author

I'm not quite sure what the CI issue related to test-latest-deps / testLatestDeps2 and test-latest-deps / testLatestDeps3 is about. Also, the console log is truncated so I think one alternative is to see it in Gradle's build scan tool: https://gradle.com/s/ychannifj3li6 - But still I can't find the link between my changes and the failed task :/

@laurit
Copy link
Contributor

laurit commented Nov 16, 2023 •
edited
Loading

@LikeTheSalad latest dep tests can start failing when there is a new version of tested library. They are not required for merging but you could get them passing by rebasing your pr.

mateuszrzeszutek
mateuszrzeszutek approved these changes Nov 17, 2023
View reviewed changes
...ion-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/SpanSuppressors.java

ByContextKey(SpanSuppressor delegate) {
this.delegate = delegate;
Method shouldSuppressInstrumentation;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad Android desugaring doesn't support MethodHandles 😢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ikr 😩

@trask trask merged commit 683c311 into open-telemetry:main Nov 17, 2023
47 checks passed
@LikeTheSalad LikeTheSalad mentioned this pull request Nov 22, 2023
Merged
@trask trask mentioned this pull request Dec 14, 2023
Open
@LikeTheSalad LikeTheSalad mentioned this pull request Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask left review comments

@laurit laurit laurit approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.32.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LikeTheSalad @laurit @trask @mateuszrzeszutek