Move capturing enduser.id attribute behind a flag #9751
Conversation
instrumentation/servlet/README.md
Outdated
| | `otel.instrumentation.servlet.experimental-span-attributes` | Boolean | `false` | Enable the capture of experimental span attributes. | | ||
| | `otel.instrumentation.servlet.experimental.enduser-span-attributes` | Boolean | `false` | Enable the capture of `enduser.id` span attribute. | |
There was a problem hiding this comment.
do you think it makes sense to generalize this from .servlet. to .common. in anticipation of #9400?
There was a problem hiding this comment.
I thought about that, but was unclear where the common flag could be documented (I guess it is in the website repo). So just added it for the servlet now. What do you suggest for the flag name? Is otel.instrumentation.common.capture-enduser.enabled that was suggested in #9400 fine?
There was a problem hiding this comment.
Is
otel.instrumentation.common.capture-enduser.enabledthat was suggested in #9400 fine?
👍
|
Heads up, #9777 also defines a common flag for capturing It would be great to resolve the differences between these two PRs. (Sorry, I just noticed this PR today) |
|
@philsttr I'll just merge this and leave resolving the differences to you :) I'll also create an issue for documenting this flag(or flags) that are added here or in your pr in the website repo |
|
Ok, I used |
|
@philsttr I merged this pr as is, you are welcome to rename the added property in your pr. |
|
Ok, I just didn't want to introduce a backwards incompatibility in case there is a release before my PR is merged. |
|
@philsttr if you don't mind sending a small PR to do the rename we can merge that quickly |
|
@trask can I get your opinion on #9777 (comment) to finalize the name/flags? |
Resolves #9740