Add process spans to aws2 sqs instrumentation #9778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
commented
Oct 31, 2023
| @@ -203,17 +207,18 @@ class S3TracingTest extends AgentInstrumentationSpecification { | |||
| "rpc.system" "aws-api" | |||
| "rpc.service" "AmazonSQS" | |||
| "http.method" "POST" | |||
| "http.status_code" 200 | |||
There was a problem hiding this comment.
should process spans have attributes that require response?
laurit
commented
Oct 31, 2023
| import java.util.Iterator; | ||
| import javax.annotation.Nullable; | ||
|
|
||
| class TracingIterator implements Iterator<Message> { |
There was a problem hiding this comment.
TracingIterator and TracingList are slightly modified copies from kafka instrumentation
laurit
commented
Oct 31, 2023
|
|
||
| public final class AwsSdkSingletons { | ||
|
|
||
| private static final boolean CAPTURE_EXPERIMENTAL_SPAN_ATTRIBUTES = |
There was a problem hiding this comment.
This class is also used in the javaagent instrumentation. Perhaps this should be copied there so it could use InstrumentationConfig?
laurit
changed the title
mateuszrzeszutek
approved these changes
Nov 8, 2023
...-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/TracingList.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr makes SQS instrumentation create similarly telemetry to kafka instrumentation, also support is added for the receive telemetry flag. Like in kafka instrumentation
processspan is created by placing messages in a custom list whose iterator creates span onnextand closes it onhasNext.Aws2 library instrumentation now requires an extra step, sqs client needs to be wrapped to support creating process spans.
Currently
processspans has all the rpc/http client attributes besides the ones that use the response. This is a bit strange as thereceivespan also has them (also including the ones that use response). Should this be changed to remove these fromprocessspan whenreceiveis enabled? Or should we always put all of these (including the ones that use response) onprocessspan?