Stable JVM semconv implementation: GC #9890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
approved these changes
Nov 16, 2023
...ry/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java8/GarbageCollector.java
Show resolved
Hide resolved
| .setExplicitBucketBoundariesAdvice(emptyList()) | ||
| .build(); | ||
| } | ||
| if (SemconvStability.emitStableJvmSemconv()) { |
There was a problem hiding this comment.
At some point we'll want to update the readme to describe how to opt into emit the new conventions.
There was a problem hiding this comment.
I'll add something in the next PR.
added 2 commits
November 17, 2023 10:26
mateuszrzeszutek
force-pushed
the
jvm-stable-gc
branch
from
c1748d8
to
f054f29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.