Bump all the dependencies #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
commented
Jun 2, 2023
| @@ -6,89 +6,90 @@ require ( | |||
| github.com/go-logr/logr v1.2.4 | |||
| github.com/oklog/ulid/v2 v2.1.0 | |||
| github.com/open-telemetry/opamp-go v0.7.0 | |||
| github.com/open-telemetry/opentelemetry-operator v1.51.0 | |||
There was a problem hiding this comment.
We should retract this version, it's what we have as latest in go.pkg.dev right now.
pavolloffay
approved these changes
Jun 5, 2023
TylerHelmuth
reviewed
Jun 5, 2023
| @@ -122,16 +121,17 @@ func NewMetricReporter( | |||
|
|
|||
| // Create some metrics that will be reported according to OpenTelemetry semantic | |||
| // conventions for process metrics (conventions are TBD for now). | |||
| reporter.processCpuTime, err = reporter.meter.Float64ObservableGauge( | |||
| reporter.processCpuTime, err = reporter.meter.Float64ObservableCounter( | |||
There was a problem hiding this comment.
Is changing this metric type a breaking change?
| ) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("can't create process time metric: %w", err) | ||
| } | ||
| reporter.processMemoryPhysical, err = reporter.meter.Float64ObservableCounter( | ||
|
|
||
| reporter.processMemoryPhysical, err = reporter.meter.Float64ObservableGauge( |
There was a problem hiding this comment.
Is changing this metric type a breaking change?
There was a problem hiding this comment.
it was previously incorrect, but also no one is using this image yet other than me pretty much because we don't have a way to deploy this yet.
TylerHelmuth
approved these changes
Jun 5, 2023
KitSutliff
pushed a commit
to KitSutliff/opentelemetry-operator
that referenced
this pull request
Jun 22, 2023
* Bump all the deps * linter
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Bump all the deps * linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another dependabot doesn't know what the hell its doing PR. This bumps all our dependencies that dependabot is trying to bump.