Create OpenShift dashboard to visualize Collector metrics #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
reviewed
May 29, 2024
pavolloffay
reviewed
Jun 4, 2024
pavolloffay
reviewed
Jun 25, 2024
pavolloffay
reviewed
Jul 3, 2024
main.go
Outdated
| err = openshiftDashboards.CreateOpenShiftDashboard(clientset) | ||
| if err == nil { | ||
| ctrl.Log.Info("OpenShift dashboard for OpenTelemetryCollector monitoring created") | ||
| defer openshiftDashboards.DeleteOpenShiftDashboard(clientset, ctrl.Log) |
There was a problem hiding this comment.
Did you test this? Otherwise we could use context.AfterFunc on the context returned from ctrl.SetupSignalHandler()
There was a problem hiding this comment.
Is this a vanilla grafana dashboard or OCP-specific? It would be great to document how this dashboard can be created/updated.
There was a problem hiding this comment.
Where should I document it? So that you know, the creation of this dashboard is reported in the release notes + flag. Regarding editing.. changes will be overwritten on operator restarts or upgrades.
It is Grafana 5 syntax.
…try#2995 Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: this PR adds the creation of OpenShift dashboards to monitor OpenTelemetry Collector instances.