Fix annotation/label filter setting #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
approved these changes
Jun 4, 2024
pavolloffay
approved these changes
Jun 4, 2024
|
Could you please set a wider test here with a similar regex mentioned in the issue? config.*.gke.io.* |
yuriolisa
approved these changes
Jun 5, 2024
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
Jun 6, 2024
* fix how options are loaded by removing special casing * oop * chlog * update to specific test * oop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a bug where annotations/label filter regexes were not being applied correctly because they were being escaped. This result in something
hello.*worldto becomehello\..*worldin a way that was opaque to the user.Link to tracking Issue(s):
Testing: Unit testing, manual testing
Documentation: n/a