-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a separate bundle for OpenShift installations #3056
base: main
Are you sure you want to change the base?
Conversation
Could you please create a changelog entry for this? |
config/manifests/community/bases/opentelemetry-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
The contributing.md should be probably updated as well |
Sure. I'll do. |
@@ -6,7 +6,7 @@ metadata: | |||
capabilities: Deep Insights | |||
categories: Logging & Tracing,Monitoring | |||
certified: "false" | |||
containerImage: ghcr.io/open-telemetry/opentelemetry-operator/opentelemetry-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this being changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can revert if you want because I don't have a strong opinion on this but I saw that other operators are versioning the image and it looks to me as a good practice that makes sense since the image is associated to a version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather it be done in a follow up, but I'm ok with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice progress 👍🏼
https://github.com/open-telemetry/opentelemetry-operator/blob/main/CONTRIBUTING.md#create-the-bundle-and-related-images needs to be updated as well.
|
||
$(OPERATOR_SDK) bundle validate ./bundle/community | ||
$(OPERATOR_SDK) bundle validate ./bundle/openshift | ||
rm bundle.Dockerfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing the bundle dockerfile? It was moved to ./bundle/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is generated again
- op: add | ||
path: "/spec/template/spec/containers/0/args" | ||
value: | ||
- --metrics-addr=127.0.0.1:8080 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to enable the RBAC creation flag as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That flag does nothing now.
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Description: create a separate bundle for OpenShift platform.
Resolves: #3054