Remove unnecessary instances of app.kubernetes.io/managed-by #3074
Conversation
… applied resources
| Labels: map[string]string{ | ||
| "app.kubernetes.io/managed-by": "opentelemetry-operator", | ||
| }, | ||
| Labels: map[string]string{}, |
There was a problem hiding this comment.
Hi @jaronoff97 ,
Just curious, after removing the filtering logic. For resources with label "app.kubernetes.io/managed-by": "Helm", could it be possible that both the helm chart and the OTel operator are managed at the same time resulting in a common modification of a resource (e.g., operator modifies the resource first, helm upgrade modifies it again)
There was a problem hiding this comment.
Different applications making changes to the same resource is a normal occurence in K8s, that by itself is not an issue. What we're fixing here is that the value of this label is a lie currently. The operator does not manage its own CRs in general, it only manages the ones it creates.
There was a problem hiding this comment.
yeah the issue today is that a collector or instrumentation created by helm will not be upgraded correctly by the operator because the label we filter isn't accurate
|
@swiatekm-sumo i think if we were going the other way (beginning to filter) that would be problematic, but this should encapsulate all collector CRs now, not just the ones created without helm. I will test this prior to merging. |
Description:
This PR resolves a bug where we applying the
app.kubernetes.io/managed-byto resources unnecessarily. We also relied on this label to be present which caused a nasty bug with instrumentation. Because we expect this to be on all CRDs and we use that for querying for upgrades, when we go to query for instrumentations, any that were applied by helm (which sets this label itself) would be omitted, causing them to fail to be upgraded. This change is technically breaking, but is also a bug fix because we are no longer failing the user expectation for auto instrumentation fixes.Link to tracking Issue(s):
Testing: Unit, manual
Documentation: