OpAMP Bridge: Applier support for OTel CRD v1beta1 API Version #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Description**: Updates the opamp bridge's config applier interface and client to support opentelemetry.io/v1beta1, explicitly removing support for applying OpenTelemetryCollector configurations of the opentelemetry.io/v1alph1 version **Link to tracking Issue(s)**: open-telemetry#2985 **Testing**: Update Documentation: n/a
jaronoff97
reviewed
Jul 1, 2024
There was a problem hiding this comment.
two minor thoughts, certainly nothing blocking. Overall this looks great though! Pretty clean implementation. Were you able to confirm the behavior of the bridge when running in a cluster that has both v1alpha1 and v1beta1 collectors? We don't have any e2e tests for this today, but it would be great to confirm this manually.
jaronoff97
approved these changes
Jul 1, 2024
swiatekm
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Updates the opamp bridge's config applier interface and client to support opentelemetry.io/v1beta1, explicitly removing support for applying OpenTelemetryCollector configurations of the opentelemetry.io/v1alph1 version
Link to tracking Issue(s): 2985
Testing: Updated existing client and agent unit tests; functionally tested the bridge by running it and making sure it didn't hit any errors at steady state.
Documentation: n/a