Enabling ipFamilies and ipFamilyPolicy #3087
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
jaronoff97
approved these changes
Jul 2, 2024
|
looks like e2e is failing here |
pavolloffay
approved these changes
Jul 3, 2024
swiatekm
reviewed
Jul 3, 2024
There was a problem hiding this comment.
Are these e2e tests checking anything a controller test wouldn't? I'd rather have that if you aren't going to check if ipv6 actually works. We could even add a controller test that sets all the optional attributes in OpenTelemetryCommonFields.
Other than that, LGTM.
Great idea, @swiatekm. I add the tests on both sides, controller and e2e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Enabling ipFamilies and ipFamilyPolicy to be configured via OpenTelemetryCollector
Link to tracking Issue(s):
Testing:
Documentation: