Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new image for bridge server e2e tests #3095

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

jaronoff97
Copy link
Contributor

Description:
Creates and builds an e2e test image for an OpAMP server with endpoints available for e2e testing

Link to tracking Issue(s):

Testing: This is testing

Documentation: n/a

@jaronoff97 jaronoff97 requested a review from a team as a code owner July 2, 2024 18:50
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was renamed!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much of this code was copied from here

@jaronoff97
Copy link
Contributor Author

jaronoff97 commented Jul 2, 2024

a follow up will use the published test image! That will be done when this is merged.

@jaronoff97 jaronoff97 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 2, 2024
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fair amount of code, so I think we should set up some basic tooling for it. We should run golangci-lint on it, for one. I'm ok with that happening in a follow-up though.

@jaronoff97 jaronoff97 merged commit 4d5fa95 into open-telemetry:main Jul 3, 2024
40 of 41 checks passed
@jaronoff97 jaronoff97 deleted the bridge-e2e-test branch July 3, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpAMP Bridge e2e testing
3 participants