Add TargetAllocator CR webhook #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
swiatekm
force-pushed
the
feat/add-targetallocator-webhook
branch
from
a4f6fe0
to
63d2840
Compare
swiatekm
force-pushed
the
feat/add-targetallocator-webhook
branch
from
63d2840
to
b183458
Compare
yuriolisa
reviewed
Jul 4, 2024
| targetAllocatorCRPolicyRules = []*rbacv1.PolicyRule{ | ||
| { | ||
| APIGroups: []string{"monitoring.coreos.com"}, | ||
| Resources: []string{"servicemonitors", "podmonitors"}, |
There was a problem hiding this comment.
I'm adding here the Probe/ScrapeConfig support. I believe you can add both resources on CRPolicyRules.
pavolloffay
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implement the TargetAllocator webhook. I've moved some functions to seperate modules to be able to reuse them between the added webhook and the existing collector webhook. Maybe we can have a common validator for OpenTelemetryCommonFields in general?
The webhook is not yet enabled in the manifests, so this change has no user-facing effect.
Link to tracking Issue(s): #2516