Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit blog post about tracetesting the OTel demo #3053

Merged
merged 12 commits into from
Jul 27, 2023
Merged

Submit blog post about tracetesting the OTel demo #3053

merged 12 commits into from
Jul 27, 2023

Conversation

adnanrahic
Copy link
Contributor

@adnanrahic adnanrahic commented Jul 18, 2023 •
edited by chalin
Loading

Hi all!

My colleague @danielbdias wrote this piece based on his recently merged tracetesting contribution to the OTel demo that uses Tracetest. I only helped with reviews and formatting. Daniel is out on holiday this week, and he asked me to submit a PR on his behalf.

We thought that it would be nice to blog about it and contribute it to the OTel blog.
Would love to hear your thoughts about it! Do you think it makes sense?

Thanks!

References:

Preview: https://deploy-preview-3053--opentelemetry.netlify.app/blog/2023/testing-otel-demo/

@adnanrahic adnanrahic requested review from a team as code owners July 18, 2023 12:53
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 18, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@svrnm svrnm added the blog label Jul 18, 2023
svrnm
svrnm reviewed Jul 19, 2023
View reviewed changes
content/en/blog/2023/testing-otel-demo/index.md Outdated
By doing that, we have a successful call to the service, and it evaluates
correctly as seen here:

![email-success-formatted.png](./email-success-formatted.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason why tracetest is used in this last screenshot and not jaeger or a console output as before? Also, the picture is really hard to parse on a small screen

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reasoning is to show the test specs and that the test is passing. I can try re-taking the screenshot and make it bigger.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a better screenshot now.

@svrnm
Copy link
Member

svrnm commented Jul 19, 2023

thanks @adnanrahic , please see the comments I have provided

@adnanrahic
Copy link
Contributor Author

Thanks @svrnm! I've applied your suggestions.

I'll re-take the final screenshot to make the screen bigger and more readable.

Is there anything else I missed?

@adnanrahic adnanrahic requested a review from svrnm July 19, 2023 13:44
@adnanrahic
Copy link
Contributor Author

Hey @svrnm ! Just wanted to let you know I've gone through and accepted your suggestions. Also replaced one image with a text snippet, and replaced a screenshot to be more visible.

LMK if you have any more ideas on edits. Thanks! 🙌

@adnanrahic adnanrahic requested a review from svrnm July 20, 2023 11:12
@adnanrahic
Copy link
Contributor Author

Hi @svrnm 👋

I've addressed all suggestions and made sure to properly format the post.
I'm happy to make additional edits if needed.

Thanks. 👌

@svrnm
Copy link
Member

svrnm commented Jul 24, 2023

@adnanrahic thanks! I'll need a few days to be able to do another round of reviews, apologies, I'll follow up with you as soon as I can.

cartermp
cartermp approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think the blog is in good shape.

chalin
chalin reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make a copyedit pass if I can soon too (though probably after @svrnm :)).

content/en/blog/2023/testing-otel-demo/index.md Outdated Show resolved Hide resolved
svrnm
svrnm reviewed Jul 25, 2023
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor issues, left, overall lgtm

Let's publish this by the end of the week/early next week as we just had another blog post yesterday

@adnanrahic
Copy link
Contributor Author

Thanks everyone!

I've applied your last edits. It looks great!

Would be awesome to see it published this week. 🙌

@svrnm
Copy link
Member

svrnm commented Jul 26, 2023

Let's publish it on Thursday then

@adnanrahic
Copy link
Contributor Author

Wonderful @svrnm ! 🙌
Thanks everyone for the reviews. 🙇

@adnanrahic
Copy link
Contributor Author

Hey @svrnm ! Just checking in to ask when you plan on merging this? Wanted to know so I can help promote it once it's published. 😄

adnanrahic and others added 11 commits July 27, 2023 10:53
@adnanrahic @chalin
blog(submit article): testing the otel demo
be8fc6d
@adnanrahic @chalin
blog(submit article): run test and format
fb017c1
@adnanrahic @chalin
blog(testing otel demo): applying suggestions
227f2e2
@adnanrahic @svrnm @chalin
Apply suggestions from code review
3abc205 
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
@adnanrahic @chalin
blog(testing otel demo): change screenshot
57cef74
@adnanrahic @chalin
blog(testing otel demo): format edits
78cc834
@adnanrahic @chalin
blog(testing otel demo): more formatting edits
4bb6357
@adnanrahic @chalin
blog(testing otel demo): more formatting :)
5cf2495
@adnanrahic @chalin
blog(testing otel demo): code formatting
01e6692
@adnanrahic @chalin @svrnm
Apply suggestions from code review
da0474a 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
@adnanrahic @svrnm @chalin
Update content/en/blog/2023/testing-otel-demo/index.md
0e05e44 
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
@chalin
Copy link
Contributor

chalin commented Jul 27, 2023

Hi @adnanrahic - I've just rebased. Can you pull the rebased PR and then run npm run fix:dict and submit the changes? That'll normalize your local cSpell words. Thanks!

@adnanrahic
Copy link
Contributor Author

Thank you @chalin ! Just pushed a commit. That should do it. 😄

@svrnm svrnm merged commit c151f9c into open-telemetry:main Jul 27, 2023
14 checks passed
@svrnm
Copy link
Member

svrnm commented Jul 27, 2023

published! https://opentelemetry.io/blog/2023/testing-otel-demo/

@adnanrahic
Copy link
Contributor Author

Thanks a lot, everyone! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin left review comments

@svrnm svrnm svrnm approved these changes

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
blog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adnanrahic @svrnm @chalin @cartermp