Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: NewsProvider - Allow the URL of a translated image to be null #5446

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jun 26, 2024

Hi everyone,

Here is a small improvement for the tagline/news, to allow empty URL on translated images.
It will reduce the size of the JSON.

@g123k g123k added the tagline label Jun 26, 2024
@g123k g123k self-assigned this Jun 26, 2024
@g123k g123k requested a review from a team as a code owner June 26, 2024 21:52
@github-actions github-actions bot added the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Jun 26, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 7.18%. Comparing base (4d9c7fc) to head (d4c585c).
Report is 229 commits behind head on develop.

Files Patch % Lines
...h_app/lib/data_models/news_feed/newsfeed_json.dart 0.00% 7 Missing ⚠️
...ib/pages/scan/carousel/main_card/scan_tagline.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5446      +/-   ##
==========================================
- Coverage     9.54%   7.18%   -2.37%     
==========================================
  Files          325     391      +66     
  Lines        16411   20384    +3973     
==========================================
- Hits          1567    1464     -103     
- Misses       14844   18920    +4076     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@g123k g123k changed the title chore: Allow the URL of a translated image to be null chore: NewsProvider - Allow the URL of a translated image to be null Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… tagline
Projects
Status: 💬 To discuss and validate
Development

Successfully merging this pull request may close these issues.

None yet

2 participants