Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tables of marks #3916

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ThomasBreuer
Copy link
Member

(I need this for the forthcoming talk at ICMS.)

  • code
  • tests
  • documentation
  • and improve the caching of character tables from the library: normalize the key such that the Oscar table gets created just once from the underlying GAP table

(I need this for the forthcoming talk at ICMS.)

- code
- tests
- documentation
and added a few more `GAP.Globals` -> `GAPWrap`
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 97.28507% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.72%. Comparing base (170478d) to head (bb52ac4).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3916      +/-   ##
==========================================
- Coverage   83.97%   83.72%   -0.26%     
==========================================
  Files         589      592       +3     
  Lines       81182    81526     +344     
==========================================
+ Hits        68174    68259      +85     
- Misses      13008    13267     +259     
Files Coverage Δ
src/GAP/wrappers.jl 95.18% <100.00%> (+0.62%) ⬆️
src/Groups/group_characters.jl 95.64% <100.00%> (+0.03%) ⬆️
src/Groups/types.jl 81.57% <ø> (ø)
src/Groups/tom.jl 96.95% <96.95%> (ø)

... and 52 files with indirect coverage changes

@ThomasBreuer ThomasBreuer added enhancement New feature or request topic: groups labels Jul 5, 2024
author = {Burnside, W.},
title = {Theory of groups of finite order},
mrnumber = {69818},
note = {2d ed},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a guess, but maybe it should be this?

Suggested change
note = {2d ed},
note = {2nd ed},

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If depends.
If we want to be consistent with MathSciNet then we should keep it as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic: groups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants