Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): regressions in graph verify for public/private & local #683

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

paularmstrong
Copy link
Owner

@paularmstrong paularmstrong commented Mar 30, 2024

Problem:

  1. Public packages were able to list private packages as production dependencies.
  2. Local workspace dependencies were skipped on actual version verification – only the integrity of the same version across the dependency graph was being verified, but not the actual declared version.

Solution:

Added checks & regression tests

Related issues:

Fixes #678, #682

Checklist:

  • Added or updated tests
  • Added or updated documentation
  • Ensured the pre-commit hooks ran successfully

@paularmstrong paularmstrong added 🐛 bug Something isn't working ⚛️ core The oneRepo core labels Mar 30, 2024
@paularmstrong
Copy link
Owner Author

cc @alecmev

Copy link

netlify bot commented Mar 30, 2024

Deploy Preview for onerepo canceled.

Name Link
🔨 Latest commit 2b7579f
🔍 Latest deploy log https://app.netlify.com/sites/onerepo/deploys/66083e4059cb79000819bd7d

@alecmev
Copy link
Contributor

alecmev commented Mar 30, 2024

Looks great, thank you! I think I'll be able to delete constraints.pro with this 😛

@paularmstrong
Copy link
Owner Author

FYI: I'll try to cut a release tomorrow

@paularmstrong paularmstrong merged commit be88279 into main Mar 30, 2024
24 checks passed
@paularmstrong paularmstrong deleted the verify-regressions branch March 30, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ⚛️ core The oneRepo core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

one graph verify doesn't force latest local version
2 participants