Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new package with examples #517

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Enzo-Demeulenaere
Copy link
Contributor

Hello, I added some examples that @rvillemeur wrote for Bloc.

They are in a separate package called 'BookletGraphicsBloc' , this package needs 'Bloc' in its name to be recognized by the demo browser.

I also tagged some of those examples to the demo browser by adding the 'demo' pragma

Some examples are still not working and need to be reviewed before being added into a future pr, also some working examples have not been added and will come later

Enzo

@Enzo-Demeulenaere
Copy link
Contributor Author

I just added other examples on my repo but I thought the commit would automatically add to this pr and it doesn't seem to be the case, do I have to create another pr to add another commit to this pr ?

@tinchodias
Copy link
Collaborator

I just added other examples on my repo but I thought the commit would automatically add to this pr and it doesn't seem to be the case, do I have to create another pr to add another commit to this pr ?

@Enzo-Demeulenaere are you sure the additional examples are not included in this PR? If they are pushed to the same source branch, it should be included, I think.

So, the idea is to have this booklet code directly here in Bloc repo, but not loaded by the baseline? would the booklet indicate loading instructions to load manually this package from here? or the idea is that the baseline loads it, too.

The examples are quite diverse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants