Added comment on BlTransformAnimation class #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added comment from Renaud
tinchodias
reviewed
Jul 3, 2024
Comment on lines
+9
to
+11
| BlTransformAnimation use BlElementAbsoluteTransformation to manage the transformation matrix, even if each transformation use BlElementLocalTransformation for its defintion. This transformation works by updating its transformation matrix, from IdentityMatrix, to target matrix, through interpolation computed at each animation step (fromMatrix interpolate: aNumber to: toMatrix) | ||
|
|
||
| This transformation doesn't use an origin point. Instead, It'll apply a translation, so that your shape still look like it's in the element bound. This translation is added to your transformation definition (boundingRectangle:) |
There was a problem hiding this comment.
Concretely, this is the comment to add, right? if this is the case, I would re-do the commit only with it. Because there is a not of noise due to Tonel version change. I don't know why this happened, since repo explicits the version to use.
There was a problem hiding this comment.
I mean, Iceberg should had taken the repo version automatically at the comment of pressing the Commit button in your IDE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was suggested by @rvillemeur to explain a bit more how the transform animation computes the transform matrix at each step of an animation