Change sentAt from Str to Int #379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a patch against a generated file - you'll need to patch the generation code in builder-lib, else the change will just get overwritten. It looks like this is set from a type of "Date", which translates to "timestamp". (See botocore/botocore/data/personalize-events/2018-03-22/service-2.json ) Timestamp is used in a number of places across the various services, so we'd need to know if this change can be to be universal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sentAt must be of type Int or it will not be serialized correctly. Current implementation causes PutEvents to fail with "class java.lang.String can not be converted to milliseconds since epoch" error.