Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize the graph shape to not create sub-graphs when possible #724

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

optimize the graph shape to not create sub-graphs when possible #724

wants to merge 35 commits into from

Commits on Jan 25, 2024

  1. lang: interfaces Add CallableFunc interface 

    Add a new interface for callable functions.
    @purpleidea
    purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    6bb5930 View commit details
    Browse the repository at this point in the history

  2. lang: funcs: structs: Add CallableFunc implementation for if func 

    Add an initial implementation for the `if` function.
    @purpleidea
    purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    f4df5a6 View commit details
    Browse the repository at this point in the history

  3. lang: funcs: structs: Add CallableFunc implementation for const func 

    Add an initial implementation for the `const` function.
    @purpleidea
    purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    bf06110 View commit details
    Browse the repository at this point in the history

  4. lang: funcs: Add CallableFunc implementation for simple and simplepoly 

    Add initial implementations for these wrapper functions.
    @purpleidea
    purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    321e89f View commit details
    Browse the repository at this point in the history

  5. lang: funcs: facts: Add CallableFunc implementation for fact 

    Add an initial implementation for this wrapper function.
    @purpleidea
    purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    a264977 View commit details
    Browse the repository at this point in the history

  6. pseudo code for the static graph optimization

    @gelisam @purpleidea
    gelisam authored and purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    d6d3bd5 View commit details
    Browse the repository at this point in the history

  7. an example which the pseudo-code does _not_ support yet

    @gelisam @purpleidea
    gelisam authored and purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    debbf55 View commit details
    Browse the repository at this point in the history

  8. pseudo code for ExprFunc.Value()

    @gelisam @purpleidea
    gelisam authored and purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    eab4f87 View commit details
    Browse the repository at this point in the history

  9. XXX: WIP

    @purpleidea
    purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    9506b02 View commit details
    Browse the repository at this point in the history

  10. XXX: WIP ExprFunc.Value

    @purpleidea
    purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    2df932a View commit details
    Browse the repository at this point in the history

  11. pseudo code for ExprCall.Value()

    @gelisam @purpleidea
    gelisam authored and purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    aa43cbf View commit details
    Browse the repository at this point in the history

  12. XXX: messy pseudo-code to fix-up more

    @purpleidea
    purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    723d2f8 View commit details
    Browse the repository at this point in the history

  13. XXX: lang: ast: Add Value speculation sentinel error 

    If it's useful, we have it... XXX
    @purpleidea
    purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    27f155f View commit details
    Browse the repository at this point in the history

  14. fill in comment

    @gelisam @purpleidea
    gelisam authored and purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    8138b5c View commit details
    Browse the repository at this point in the history

  15. remove outdated comment 

    we do include obj.Args in the ordering logic now.
    @gelisam @purpleidea
    gelisam authored and purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    b9b9796 View commit details
    Browse the repository at this point in the history

  16. answer to XXX comment in commit description 

    we cover the args and the body, that covers both the newly-bound
variables and all the variable usages in a lambda.

builtins don't need ordering arrows because builtins are available from
the beginning, there is no question about whether they should be
processed before or after a given Stmt.
    @gelisam @purpleidea
    gelisam authored and purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    29341a0 View commit details
    Browse the repository at this point in the history

  17. explain what to do in the obj.Values case

    @gelisam @purpleidea
    gelisam authored and purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    94455ee View commit details
    Browse the repository at this point in the history

  18. yes, I did mean arg.Graph()

    @gelisam @purpleidea
    gelisam authored and purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    d4270af View commit details
    Browse the repository at this point in the history

  19. better error message

    @gelisam @purpleidea
    gelisam authored and purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    d29983e View commit details
    Browse the repository at this point in the history

  20. reword comment in the hope it is clear this time

    @gelisam @purpleidea
    gelisam authored and purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    899b5d5 View commit details
    Browse the repository at this point in the history

  21. CheckParamScope

    @gelisam @purpleidea
    gelisam authored and purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    eba4f9d View commit details
    Browse the repository at this point in the history

  22. start with the empty environment

    @gelisam @purpleidea
    gelisam authored and purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    9a4c1ad View commit details
    Browse the repository at this point in the history

  23. ExprAny.CheckParamScope()

    @gelisam @purpleidea
    gelisam authored and purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    42d529b View commit details
    Browse the repository at this point in the history

  24. XXX fixes so we compile

    @purpleidea
    purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    0ad1df2 View commit details
    Browse the repository at this point in the history

  25. XXX: COMPLETELY GUESSING, PROBABLY WRONG

    @purpleidea
    purpleidea committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    2c2df8f View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Revert "XXX: COMPLETELY GUESSING, PROBABLY WRONG" 

    This reverts commit 2c2df8f.

It is indeed wrong. We need to implement a new method to full.FuncValue,
not bend over backwards to reuse Func's method.
    @gelisam
    gelisam committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    d61a5df View commit details
    Browse the repository at this point in the history

  2. remove unused helper function NewFunc

    @gelisam
    gelisam committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    7ad1382 View commit details
    Browse the repository at this point in the history

  3. remove unused helper FuncValue.Func()

    @gelisam
    gelisam committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    b957901 View commit details
    Browse the repository at this point in the history

  4. remove unused helper FuncValue.Set()

    @gelisam
    gelisam committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    44e3c06 View commit details
    Browse the repository at this point in the history

  5. support for Timeless FuncValues

    @gelisam
    gelisam committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    87c0967 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. fix callers

    @gelisam
    gelisam committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    2c41e67 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. missing txn.Commit()

    @gelisam
    gelisam committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    8caf0a7 View commit details
    Browse the repository at this point in the history

  2. ExprCall.Value()

    @gelisam
    gelisam committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    e25c9a6 View commit details
    Browse the repository at this point in the history

  3. a regular error, not a panic

    @gelisam
    gelisam committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    2852f2e View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. copy obj.function to avoid sharing

    @gelisam
    gelisam committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    c56211f View commit details
    Browse the repository at this point in the history