fix allows_any() with local versions

[dimbleby]

Make allows_any() more like intersect().

It doesn't make sense that 1.2.3+cpu and 1.2.3 have an intersection (at 1.2.3+cpu), while "1.2.3+cpu".allows_any("1.2.3") is False.

(Possible alternative implementation is just to take the intersection and ask whether it is empty. Conceptually that's clean, perhaps it's pointless to worry about the unnecessary construction of the EmptyConstraint() when the answer is "no").

see also python-poetry/poetry#7876

[dimbleby]

ugh, as always, things get worse when you look at them!

#!/usr/bin/env python3

from poetry.core.constraints.version import Version, VersionRange

v123 = Version.parse("1.2.3")
v123_local = Version.parse("1.2.3+local")
v123_local_etc = VersionRange(min=v123_local, include_min=True)

print(f"{v123_local.intersect(v123).is_empty()=}")
print(f"{v123_local_etc.intersect(v123).is_empty()=}")

the range v123_local_etc is surely larger than the individual version v123_local, so it doesn't make a lot of sense that the second intersection is empty and the first is not.

[dimbleby]

another paradox in the current implementation:

v123 = Version.parse("1.2.3")
v123_local = Version.parse("1.2.3+local")
v123_local_etc = VersionRange(min=v123_local, include_min=True)

print(f"{v123.allows(v123_local)=}")
print(f"{v123.allows_any(v123_local_etc)=}")

1.2.3 allows 1.2.3+local, but does not allow any of >=1.2.3+local

[dimbleby]

Not planning on doing anything more with this, AFAIK it should be good to merge. Confirmed that this allows the sequence:

$ poetry source add --default pytorch-index https://download.pytorch.org/whl/cu118
$ poetry add torch torchvision torchaudio

to work

I think it's maybe still wrong when calculating the intersection of eg "1.2.3" and "<=1.2.3+local" which ought to be a range something like ">=1.2.3, <=1.2.3+local" but today probably comes out as just "1.2.3". However I don't have the enthusiasm to do anything about that now, and this MR should be a clear improvement even if there is more that could be done. Maybe another time.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information