Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve use of subprocess #602

Merged
merged 2 commits into from
Jun 9, 2023
Merged

improve use of subprocess #602

merged 2 commits into from
Jun 9, 2023

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Jun 4, 2023 •
edited
Loading

a companion to python-poetry/poetry#8060, using text=True for subprocess.

@dimbleby dimbleby force-pushed the text-subprocess branch 2 times, most recently from 1ec6d25 to f7e8ae9 Compare June 4, 2023 14:02
@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@radoering radoering merged commit ac81c3b into python-poetry:main Jun 9, 2023
20 checks passed
@dimbleby dimbleby deleted the text-subprocess branch June 9, 2023 19:50
@radoering radoering mentioned this pull request Aug 19, 2023
Merged
@dimbleby dimbleby mentioned this pull request Aug 22, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radoering radoering radoering approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dimbleby @radoering